Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make header stick to top on all sites #67

Closed
iandunn opened this issue Jan 10, 2022 · 4 comments · Fixed by #96
Closed

Make header stick to top on all sites #67

iandunn opened this issue Jan 10, 2022 · 4 comments · Fixed by #96
Assignees
Labels
[Type] Enhancement New feature or request
Milestone

Comments

@iandunn
Copy link
Member

iandunn commented Jan 10, 2022

right now it's only being done by the news theme, but the global header should have it even if there isn't a local header, or a container around the global header.

maybe duplicating the markup should be moved from the theme templates to this repo, to make sure it's done consistently, and to make the templates less cluttered. cc @shaunandrews , since it sounds like you may have an alternative to double-markup hack

@iandunn iandunn added the [Type] Enhancement New feature or request label Jan 10, 2022
@iandunn iandunn added this to the News launch milestone Jan 10, 2022
@ryelle
Copy link
Contributor

ryelle commented Jan 13, 2022

Is the issue here that the header should be stuck to the top on all sites?

@iandunn
Copy link
Member Author

iandunn commented Jan 13, 2022

yeah

@shaunandrews
Copy link

Over in WordPress/wporg-news-2021#178 I used position: sticky along with flex to handle the positioning of the elements. I'm not sure how well that will work across all the w.org sites.

@iandunn
Copy link
Member Author

iandunn commented Jan 14, 2022

Yeah, we should probably use the same method for consistency, and move the styles out of the theme for DRYness, if that's practical.

I'll make the title more generic

@iandunn iandunn changed the title Set position: fixed globally Make header stick to top on all sites Jan 14, 2022
@ryelle ryelle self-assigned this Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants