Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search won't close when we click the Close x button #92

Closed
tellyworth opened this issue Jan 11, 2022 · 6 comments
Closed

Search won't close when we click the Close x button #92

tellyworth opened this issue Jan 11, 2022 · 6 comments
Labels
[Status] Blocked Can't move forward until something outside the issue/PR is resolved

Comments

@tellyworth
Copy link
Contributor

RPReplay_Final1641469743.MP4
@ryelle
Copy link
Contributor

ryelle commented Jan 13, 2022

Same thing happens with the nav menu. This only applies to touch events, I can't replicate with a mouse, but I can on my phone and in a browser if I enable touch simulation

Screen Shot 2022-01-13 at 1 16 50 PM

@ryelle ryelle transferred this issue from WordPress/wporg-news-2021 Jan 14, 2022
@ryelle ryelle self-assigned this Jan 14, 2022
@ryelle
Copy link
Contributor

ryelle commented Jan 14, 2022

Looks like this is a gutenbug, reported here: WordPress/gutenberg#37996

@ryelle ryelle added the [Status] Blocked Can't move forward until something outside the issue/PR is resolved label Jan 14, 2022
@ryelle ryelle removed their assignment Jan 14, 2022
@iandunn iandunn added this to the News launch milestone Jan 14, 2022
@ryelle
Copy link
Contributor

ryelle commented Jan 20, 2022

This was fixed in Gutenberg 12.5, which I think won't be released for another 2 weeks. But once the site is updated, we can re-test and close this issue.

@tellyworth
Copy link
Contributor Author

Given that it's fixed upstream I think we should launch with it and close the issue once we've updated and tested to verify.

I think that means we should change the milestone to post-launch?

@dd32
Copy link
Member

dd32 commented Jan 24, 2022

Since this has been fixed upstream in Gutenberg, and ported to trunk, but a Gutenberg release hasn't been made.. I've deactivated Gutenberg on these sites to fix this..

  • Main Network
  • Global Network
  • Make Network
  • Profiles.wordpress.org

The header doesn't need Gutenberg, and is running better without it (due to this bug).

These sites still have Gutenberg enabled, which will cause this problem:

@dd32
Copy link
Member

dd32 commented Feb 3, 2022

Gutenberg 12.5.0 has finally been released, which has brought the fix required to the sites running Gutenberg.

@dd32 dd32 closed this as completed Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Blocked Can't move forward until something outside the issue/PR is resolved
Projects
None yet
Development

No branches or pull requests

4 participants