Dynamically assign active-menu-item to the menu

[dd32]

This is probably not the most efficient way, but is more dynamic than what we currently use on WordPress.org (which is mostly a tightly coupled if-branching setup).

Some style changes were required to make submenu active highlighting work more correctly, see below screenshots of the after effect.

Screen.Recording.2022-01-11.at.3.22.22.pm.mov

And for the reasoning for the CSS rotation:

See #35

[iandunn]

This looks good 👍🏻

The only thing I might change is that get_menu_url_for_current_page() feels a bit complicated, but I don't have any ideas for simplifying it. So I'd go ahead and merge 👍🏻

[dd32]

The only thing I might change is that get_menu_url_for_current_page() feels a bit complicated

@iandunn I also felt that, which is why I extracted the logic from set_current_item_class() directly to start with (and it was simpler then..).

I'd love to simplify this in future, I just wasn't able to figure out anything more reliable given the menu doesn't know if it's pointing to get_permalink(), home_url('/'), or a combination of them. Might be able to add some flags into the menu array to start with, but then Rosetta dynamic menu's kicks in and throws a spanner in there :)

[iandunn]

👍🏻