Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Clarifications to Guidelines re Privacy and Advertising. #66
WIP: Clarifications to Guidelines re Privacy and Advertising. #66
Changes from 13 commits
10e3bfd
1aab57a
e3a15be
0505f23
bd53031
25b5ddd
1eb24af
7e2a57e
cdc2af3
c32fe89
cf89e2e
32b34ff
a040625
08febe9
d8ac34c
d2b7f8f
55be916
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean they can't offer a newer version as a download from their own site? For example, authors might want to do a slow release via their own site before opening the floodgates when its uploaded to wordpress.org
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as you're planning to keep the code updated here, that's fine. We're talking about people who put a known-bad version on .org and then the GOOD version up on their site, with no intention to update here. They just want the SEO juice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love when real-world context accompanies the rules. It provides much-needed clarification as to what the intent of the rule is. I’d love to see this entire document include more snippets like this.
I wonder if there is some way to add styling to these kinds of additions. They read somewhat more casual, but really are useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some guidelines need more context than others. "No Non-GPL code" doesn't but "Your responsible for your code" does (Guideline 2 is next on my hitlist). I'm always worried about making things too long :(