Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't save backup codes until user clicks All Finished #256

Open
iandunn opened this issue Sep 20, 2023 · 0 comments
Open

Don't save backup codes until user clicks All Finished #256

iandunn opened this issue Sep 20, 2023 · 0 comments

Comments

@iandunn
Copy link
Member

iandunn commented Sep 20, 2023 •
edited
Loading

Right now the codes are saved immediately when the user visits the page. That's due to WordPress/two-factor#507, and is bad for the reasons described there.

Once that issue is fixed upstream, we should update the workflow in our client to this:

  1. Generated codes
  2. Show them to the user
  3. Wait for the user to click All Finished
  4. If (and only if) they click that, then save them to the database

Related #250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iandunn @StevenDufresne