Skip to content

Commit

Permalink
ci: Fix canary releases (#2228)
Browse files Browse the repository at this point in the history
Lerna doesn't seem to support the `canary` option anymore when creating prereleases. The command doesn't work correctly for us anyways, so I'm removing it. From what I can gather (docs don't mention it and info is sparse), it is supposed to create a pre-id using previous tags and the number of commits between the last tag and the current `HEAD`. But this caused problems for us for a long time because we release with every commit on `master` which caused the commit count to repeat and caused the order of versions to be listed out of order. We started using CI build numbers to fix the problem [#1281](95b31c1).

[category:Infrastructure]
  • Loading branch information
NicholasBoll committed May 18, 2023
1 parent 2c79134 commit 41766d8
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion utils/publish-canary.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@ exec('git diff --name-only HEAD HEAD^')
const lernaFlags = [
`--yes`,
`--force-publish="*"`,
`--canary`,
`--preid ${preid}`,
`--dist-tag ${distTag}`,
bump,
Expand Down

0 comments on commit 41766d8

Please sign in to comment.