Skip to content

Commit

Permalink
fix(button): Update missed css styles for buttons (#260)
Browse files Browse the repository at this point in the history
* fix(button): Update missed css styles for buttons

* fix(button): Remove css font style, fix story for deprecated button
  • Loading branch information
mannycarrera4 authored and lychyi committed Oct 18, 2019
1 parent 4cfe4aa commit c6a320c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
9 changes: 6 additions & 3 deletions modules/button/css/lib/button.scss
Expand Up @@ -16,13 +16,14 @@ $_wdc-btn-caret-down-icon-white: svg-load(
content: '';
background-image: $_icon;
background-position: center;
background-size: $wdc-spacing-s;
background-size: $wdc-spacing-m;
background-repeat: no-repeat;
}

@mixin wdc-btn() {
@include wdc-type-body();
@include wdc-type-variant-btn();
@include wdc-type();
display: inline-block;
text-decoration: none;
min-width: 96px;
Expand All @@ -41,6 +42,9 @@ $_wdc-btn-caret-down-icon-white: svg-load(
vertical-align: middle;
border: 2px solid transparent;
font-weight: 700;
white-space: nowrap;
text-overflow: ellipsis;
overflow: hidden;

&.wdc-btn-hover,
&:hover {
Expand Down Expand Up @@ -73,7 +77,7 @@ $_wdc-btn-caret-down-icon-white: svg-load(

&.wdc-btn-dropdown {
padding-left: $wdc-spacing-l;
padding-right: $wdc-spacing-s;
padding-right: $wdc-spacing-l;
display: inline-flex;
align-items: center;

Expand Down Expand Up @@ -114,7 +118,6 @@ $_wdc-btn-caret-down-icon-white: svg-load(
height: $wdc-spacing-l;
padding: 0 $wdc-spacing-s;
min-width: $wdc-spacing-xxxl;
-webkit-font-smoothing: subpixel-antialiased;
}

&.wdc-btn-primary {
Expand Down
2 changes: 1 addition & 1 deletion modules/button/css/stories.tsx
Expand Up @@ -177,7 +177,7 @@ storiesOf('CSS/Button/Deprecated', module)
</button>
<h3>Small Secondary</h3>
<button className="wdc-btn-deprecated wdc-btn-size-s">Secondary Button</button>
<button disabled={true} className="wdc-btn wdc-btn-size-s">
<button disabled={true} className="wdc-btn-deprecated wdc-btn-size-s">
Secondary Button
</button>
<h3>Growing Secondary</h3>
Expand Down

0 comments on commit c6a320c

Please sign in to comment.