Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(SidePanel): API update and fixes #123

Merged
merged 10 commits into from
Sep 5, 2019

Conversation

anicholls
Copy link
Contributor

@anicholls anicholls commented Aug 14, 2019

Summary

SidePanel needs a changes to bring it in line with our API & Pattern Guidelines:

  • Change sidePanelBackgroundColor to backgroundColor
  • Not Breaking: Change open param in onBreakpointChange to aboveBreakpoint. We shouldn't suggest the behavior - consumers can do what they want with the return value.
  • Bonus: There were lots of undefined styles being applied based on conditionals in the styled components. Note: use undefined instead of '' in emotion ternaries.

Closes #105.

Visual Code
Breaking Changes No Yes

Code

  • sidePanelBackgroundColor prop has been renamed to backgroundColor.

Checklist

  • branch has been rebased on the latest master commit
  • tests are changed or added
  • yarn test passes
  • all (dev)dependencies that the module needs is added to its package.json
  • code has been documented and, if applicable, usage described in README.md
  • module has been added to canvas-kit-react and/or canvas-kit-css universal modules, if
    applicable
  • design approved final implementation
  • a11y approved final implementation
  • code adheres to the API & Pattern guidelines

@anicholls anicholls added the breaking-change A change that will break something for consumers label Aug 14, 2019
@anicholls anicholls added this to In progress in Canvas Kit API Changes via automation Aug 14, 2019
@anicholls anicholls merged commit 539a68c into Workday:master Sep 5, 2019
Canvas Kit API Changes automation moved this from In progress to Done Sep 5, 2019
@anicholls anicholls deleted the sidepanel-api-updates branch September 5, 2019 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change A change that will break something for consumers
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

SidePanel API Updates
3 participants