Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixing Alert and Error radio button examples #2197

Merged
merged 7 commits into from
May 25, 2023

Conversation

williamjstanton
Copy link
Collaborator

@williamjstanton williamjstanton commented May 3, 2023

Summary

Fixes: #2196

The examples for the Alert and Error radio groups were not accessible to the keyboard because the disabled property was set on an already pre-selected input. This was a good example of something not to do!

Release Category

Components


Checklist

  • MDX documentation adheres to Canvas Kit's standard MDX template
  • Label ready for review has been added to PR

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)
  • PR Release Notes describes additional information useful to call out in a release message or removed if not applicable
  • Breaking Changes provides useful information to upgrade to this code or removed if not applicable

Where Should the Reviewer Start?

Areas for Feedback? (optional)

  • Code
  • Documentation
  • Testing
  • Codemods

Testing Manually

Review the rendered examples for Alert and Error. Validate they can receive keyboard focus, and, the values can be set using the arrow keys.

Screenshots or GIFs (if applicable)

Thank You Gif (optional)

Note about pre-selecting a radio button that is also disabled will break accessibility for the entire radio group.
@cypress
Copy link

cypress bot commented May 3, 2023

1 flaky tests on run #5789 ↗︎

0 882 2 0 Flakiness 1

Details:

Merge cdc51cb into 203dc9c...
Project: canvas-kit Commit: a9444ae4a2 ℹ️
Status: Passed Duration: 08:40 💡
Started: May 24, 2023 10:41 PM Ended: May 24, 2023 10:50 PM
Flakiness  cypress/integration/Autocomplete.spec.ts • 1 flaky test

View Output Video

Test Artifacts
... > when a value is entered > when down arrow key is pressed > when the user presses the enter key > when the use hits the "2" key > should change the filtered results Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@jamesfan jamesfan added the on hold PR is on hold until further notice label May 8, 2023
@jamesfan
Copy link
Member

jamesfan commented May 8, 2023

Putting this on brief hold to focus on the v9 release on 5/10

@alanbsmith alanbsmith removed the on hold PR is on hold until further notice label May 15, 2023
@mannycarrera4 mannycarrera4 changed the title Fixing Alert and Error radio button examples fix: Fixing Alert and Error radio button examples May 18, 2023
@myvuuu myvuuu requested a review from mannycarrera4 May 19, 2023 17:43
@alanbsmith alanbsmith merged commit b6c4813 into Workday:master May 25, 2023
15 checks passed
@williamjstanton williamjstanton deleted the william-fix-radio-examples branch July 7, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alert and Error radio group examples cannot be operated with the keyboard
4 participants