-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixing Alert and Error radio button examples #2197
Merged
alanbsmith
merged 7 commits into
Workday:master
from
williamjstanton:william-fix-radio-examples
May 25, 2023
Merged
fix: Fixing Alert and Error radio button examples #2197
alanbsmith
merged 7 commits into
Workday:master
from
williamjstanton:william-fix-radio-examples
May 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note about pre-selecting a radio button that is also disabled will break accessibility for the entire radio group.
1 flaky tests on run #5789 ↗︎Details:
|
Putting this on brief hold to focus on the v9 release on 5/10 |
mannycarrera4
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #2196
The examples for the Alert and Error radio groups were not accessible to the keyboard because the disabled property was set on an already pre-selected input. This was a good example of something not to do!
Release Category
Components
Checklist
ready for review
has been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
Review the rendered examples for Alert and Error. Validate they can receive keyboard focus, and, the values can be set using the arrow keys.
Screenshots or GIFs (if applicable)
Thank You Gif (optional)