Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Radio remove spreading of all duplicate props on Styled Radio #2745

Closed
wants to merge 1 commit into from
Closed

fix: Radio remove spreading of all duplicate props on Styled Radio #2745

wants to merge 1 commit into from

Conversation

mannycarrera4
Copy link
Contributor

@mannycarrera4 mannycarrera4 commented May 16, 2024 •
edited

Summary

Fixes: #2744
Only spread props to input on the StyledRadio

Release Category

Components

Checklist

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)
  • PR Release Notes describes additional information useful to call out in a release message or removed if not applicable
  • Breaking Changes provides useful information to upgrade to this code or removed if not applicable

Where Should the Reviewer Start?

Areas for Feedback? (optional)

  • Code
  • Documentation
  • Testing
  • Codemods

Testing Manually

Screenshots or GIFs (if applicable)

Thank You Gif (optional)

@cypress Cypress
Copy link

cypress bot commented May 16, 2024

Passing run #7304 ↗︎

0 881 3 0 Flakiness 0

Details:

Merge 799f558 into a24167f...
Project: canvas-kit Commit: 3324191305 ℹ️
Status: Passed Duration: 05:02 💡
Started: May 16, 2024 8:00 PM Ended: May 16, 2024 8:05 PM

Review all test suite changes for PR #2745 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mannycarrera4