Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: WIP Fix TableRow #2757

Closed
wants to merge 1 commit into from
Closed

Conversation

alanbsmith
Copy link
Member

Summary

Fixes: #1234

Release Category

Components

Release Note

Optional release note message. Changelog and release summaries will contain a pull request title. This section will add additional notes under that title. This section is not a summary, but something extra to point out in release notes. An example might be calling out breaking changes in a labs component or minor visual changes that need visual regression updates. Remove this section if no additional release notes are required.

BREAKING CHANGES

Optional breaking changes message. If your PR includes breaking changes. It is extremely rare to put breaking changes outside a prerelease/major branch. Anything in this section will show up in release notes. Remove this section if no breaking changes are present.


Checklist

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)
  • PR Release Notes describes additional information useful to call out in a release message or removed if not applicable
  • Breaking Changes provides useful information to upgrade to this code or removed if not applicable

Where Should the Reviewer Start?

Areas for Feedback? (optional)

  • Code
  • Documentation
  • Testing
  • Codemods

Testing Manually

Screenshots or GIFs (if applicable)

Thank You Gif (optional)

Copy link

cypress bot commented May 24, 2024

Passing run #7351 ↗︎

0 970 3 0 Flakiness 0

Details:

Merge 8efcb1b into 17945e6...
Project: canvas-kit Commit: 91b6d75469 ℹ️
Status: Passed Duration: 05:09 💡
Started: May 24, 2024 10:30 PM Ended: May 24, 2024 10:36 PM

Review all test suite changes for PR #2757 ↗︎

@josh-bagwell
Copy link
Contributor

PR #2759 should address this and this can be closed.

@mannycarrera4
Copy link
Contributor

looks like this was fixed in #2759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants