Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add robust example in storybook for ToolbarDropdown button #2782

Conversation

NehaAhujaa
Copy link
Contributor

@NehaAhujaa NehaAhujaa commented Jun 14, 2024

Summary

Fixes: #2730

Release Category

Documentation


Checklist

For the Reviewer

  • PR title is short and descriptive
  • PR summary describes the change (Fixes/Resolves linked correctly)
  • [na] PR Release Notes describes additional information useful to call out in a release message or removed if not applicable
  • [na] Breaking Changes provides useful information to upgrade to this code or removed if not applicable

Where Should the Reviewer Start?

Areas for Feedback? (optional)

  • Code
  • Documentation
  • Testing
  • Codemods

Testing Manually

Screenshots or GIFs (if applicable)

Before:

Screenshot 2024-06-14 at 14 58 08

After:

Screenshot 2024-06-17 at 14 13 34

Thank You Gif (optional)

Copy link

cypress bot commented Jun 17, 2024

Passing run #7372 ↗︎

0 974 3 0 Flakiness 0

Details:

Merge 2591771 into 60128be...
Project: canvas-kit Commit: 0a89cf71f5 ℹ️
Status: Passed Duration: 05:14 💡
Started: Jun 17, 2024 9:49 PM Ended: Jun 17, 2024 9:54 PM

Review all test suite changes for PR #2782 ↗︎

@mannycarrera4
Copy link
Contributor

mannycarrera4 commented Jun 17, 2024

Thank you Neha for making our docs better! Small suggestion, maybe use an icon and text for the menu list that might reflect a more real life example. If you use alignLeftIcon and then the options can be text that says let align, center align, right align.

@NehaAhujaa
Copy link
Contributor Author

Thank you Neha for making our docs better! Small suggestion, maybe use an icon and text for the menu list that might reflect a more real life example. If you use alignLeftIcon and then the options can be text that says let align, center align, right align.

@mannycarrera4 Thank you, Manuel! Incorporated the suggested changes to make example meaningful.

<Menu.Card>
<Menu.List>
<Menu.Item
aria-label="Expand All"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aria label is not needed unless we have an icon.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yes, makes sense! My bad there!

Copy link
Contributor

@mannycarrera4 mannycarrera4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving our docs!

@mannycarrera4 mannycarrera4 changed the title chore(Button): Add robust example in storybook for ToolbarDropdown button chore: Add robust example in storybook for ToolbarDropdown button Jun 17, 2024
@alanbsmith alanbsmith merged commit 152babe into Workday:master Jun 17, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We should add a more robust example to our ToolbarDropdownButton documentation.
3 participants