-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add robust example in storybook for ToolbarDropdown button #2782
chore: Add robust example in storybook for ToolbarDropdown button #2782
Conversation
Passing run #7372 ↗︎Details:
Review all test suite changes for PR #2782 ↗︎ |
Thank you Neha for making our docs better! Small suggestion, maybe use an icon and text for the menu list that might reflect a more real life example. If you use |
@mannycarrera4 Thank you, Manuel! Incorporated the suggested changes to make example meaningful. |
<Menu.Card> | ||
<Menu.List> | ||
<Menu.Item | ||
aria-label="Expand All" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aria label is not needed unless we have an icon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yes, makes sense! My bad there!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving our docs!
Summary
Fixes: #2730
Release Category
Documentation
Checklist
ready for review
has been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
Screenshots or GIFs (if applicable)
Before:
After:
Thank You Gif (optional)