fix: Avoid polyfill requirements #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anicholls
force-pushed
the
fix-use-theme-check
branch
from
0b45c7d
to
1131f73
Compare
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
lychyi
reviewed
Mar 3, 2020
|
Hmm. Maybe we should update our Or perhaps an ESLint rule for detecting compat features? https://www.npmjs.com/package/eslint-plugin-compat |
NicholasBoll
approved these changes
Mar 3, 2020
anicholls
changed the title
|
@NicholasBoll @lychyi After adding the linting rule, I found two more issues: I fixed both, so we should be good now! |
codytowstik
reviewed
Mar 4, 2020
Co-Authored-By: Cody Towstik <ctowstik@gmail.com>
anicholls
force-pushed
the
fix-use-theme-check
branch
from
78298d3
to
f3d776a
Compare
Merged
lychyi
pushed a commit
that referenced
this pull request
Apr 13, 2020
* refactor(icon): Update to remove Object.entries usage * feat: Add linting for browser compatible functions * fix: Fix two browser compatibility issues * refactor(icon): Simplify color lookup Co-Authored-By: Cody Towstik <ctowstik@gmail.com> * fix(core): Use Object.keys instead of Object.entries Co-authored-by: Cody Towstik <ctowstik@gmail.com>
lychyi
pushed a commit
to lychyi/canvas-kit
that referenced
this pull request
Apr 13, 2020
* refactor(icon): Update to remove Object.entries usage * feat: Add linting for browser compatible functions * fix: Fix two browser compatibility issues * refactor(icon): Simplify color lookup Co-Authored-By: Cody Towstik <ctowstik@gmail.com> * fix(core): Use Object.keys instead of Object.entries Co-authored-by: Cody Towstik <ctowstik@gmail.com>
lychyi
added a commit
that referenced
this pull request
Apr 13, 2020
* refactor(icon): Update to remove Object.entries usage * feat: Add linting for browser compatible functions * fix: Fix two browser compatibility issues * refactor(icon): Simplify color lookup Co-Authored-By: Cody Towstik <ctowstik@gmail.com> * fix(core): Use Object.keys instead of Object.entries Co-authored-by: Cody Towstik <ctowstik@gmail.com> Co-authored-by: Alex Nicholls <anicholls3@gmail.com> Co-authored-by: Cody Towstik <ctowstik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were unnecessarily using
Object.entriesin the check for an empty context inuseTheme. This function requires a polyfill in IE 11, so I've switched it to useObject.keysinstead, since this is equivalent for checking whether an object is empty.Continued:
After a bit more exploration, we were using several functions that required polyfills. This PR now adds a lint check to ensure we don't do this in the future.