Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Move theme functionality from labs to common #594

Merged
merged 19 commits into from Apr 29, 2020
Merged

chore: Move theme functionality from labs to common #594

merged 19 commits into from Apr 29, 2020

Conversation

mannycarrera4
Copy link
Contributor

@mannycarrera4 mannycarrera4 commented Apr 23, 2020 •
edited by anicholls

Summary

As we move things out of Labs, we're also trying to move all the theming functionality into common and stabilize it. This PR moves most of the stuff from labs theming into core.

Things that changed:

  •  Updated github actions to v2
  •  Moved all of lib/theming folder from labs to common
  •  CanvasProvider now lives under common/lib
  •  Updated dependencies to now import themed methods from common
  •  Moved Direction and Theme stories under Tokens|Common/Theming
  •  Every folder in common now has an index in which it exports it's files and then common itself has an index.ts that exports all those index files. This meant that some default exports had to be removed.

@mannycarrera4 mannycarrera4 changed the title Mc move theme to common chore: Move theme functionality from labs to common Apr 23, 2020
@mannycarrera4 mannycarrera4 marked this pull request as ready for review April 24, 2020 15:01
@lychyi lychyi added this to In Progress in Current Sprint (7/20 - 8/9) via automation Apr 27, 2020
@cypress
Copy link

cypress bot commented Apr 28, 2020 •
edited


Test summary

333 • 0 • 1 • 0

Run details
Project canvas-kit
Status Passed
Commit fe66c37 ℹ️
Started Apr 29, 2020 8:53 PM
Ended Apr 29, 2020 8:56 PM
Duration 03:11 💡
OS Linux Ubuntu Linux - 18.04
Browser Electron 80

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@anicholls anicholls added this to the v4.0.0 milestone Apr 28, 2020
@anicholls anicholls added 4.x breaking-change A change that will break something for consumers labels Apr 28, 2020
anicholls
anicholls suggested changes Apr 28, 2020
View reviewed changes
modules/common/react/index.ts Outdated Show resolved Hide resolved
modules/common/react/lib/theming/index.ts Outdated Show resolved Hide resolved
modules/common/react/lib/theming/index.ts Outdated Show resolved Hide resolved
modules/_labs/core/react/README.md Outdated Show resolved Hide resolved
modules/common/react/lib/theming/README.md Show resolved Hide resolved
Current Sprint (7/20 - 8/9) automation moved this from In Progress to Needs Review Apr 28, 2020
@anicholls anicholls mentioned this pull request Apr 28, 2020
Merged
@mannycarrera4 mannycarrera4 merged commit 44307b4 into Workday:prerelease/v4 Apr 29, 2020
Current Sprint (7/20 - 8/9) automation moved this from Needs Review to Done Apr 29, 2020
@anicholls anicholls mentioned this pull request May 5, 2020
Merged
@anicholls anicholls mentioned this pull request Jun 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anicholls anicholls anicholls approved these changes

Assignees
No one assigned
Labels
4.x breaking-change A change that will break something for consumers
Projects
No open projects
Current Sprint (7/20 - 8/9)
Done
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mannycarrera4 @anicholls