fix(toast): Remove transform origin for visual stories #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
This contains some of the same code as #600 which is against master. Should we just merge |
|
Works for me @NicholasBoll |
|
Solved in #600 once we merged master forward into pre release v4 |
anicholls
added
the
blocked
|
@mannycarrera4 Don't you still need to pass FYI, master changes are going in w/ #623 |
|
ah yeah, in that case, I can just delete all the transform origin stuff since that went into master, and pass null to the story |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Chromatic takes its snapshot, the
Toasthasn't animated into view so the snapshots look empty, by allowing a transform origin of null, we get to have our snapshots back.