Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 New Component: SidePanel (Labs) #866

Merged
merged 59 commits into from
Nov 6, 2020
Merged

🚀 New Component: SidePanel (Labs) #866

merged 59 commits into from
Nov 6, 2020

Commits on Aug 21, 2020

  1. feat(side-panel): Init Labs Side Panel

    @lychyi
    lychyi committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    c173fd6 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2020

  1. feat(side-panel): Add todo item

    @lychyi
    lychyi committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    1ab9273 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2020

  1. Merge branch 'master' of https://github.com/Workday/canvas-kit into s… 

    …idepanel
    @lychyi
    lychyi committed Aug 31, 2020
    Configuration menu
    Copy the full SHA
    7a0125a View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2020

  1. Merge branch 'master' of https://github.com/Workday/canvas-kit into s… 

    …idepanel
    @lychyi
    lychyi committed Sep 12, 2020
    Configuration menu
    Copy the full SHA
    a42345b View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2020

  1. feat(side-panel): Init Side Panel

    @lychyi
    lychyi committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    a9e88a5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/Workday/canvas-kit into s… 

    …idepanel
    @lychyi
    lychyi committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    6ae4407 View commit details
    Browse the repository at this point in the history

  3. chore(side-panel): Add notes

    @lychyi
    lychyi committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    ae32fbd View commit details
    Browse the repository at this point in the history

  4. feat(side-panel): Return isControlled boolean

    @lychyi
    lychyi committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    6a19f27 View commit details
    Browse the repository at this point in the history

  5. fix(side-panel): Change default height

    @lychyi
    lychyi committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    9690f43 View commit details
    Browse the repository at this point in the history

  6. test(side-panel): Clean up visual tests

    @lychyi
    lychyi committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    b133b32 View commit details
    Browse the repository at this point in the history

  7. perf(common): Optimize useUniqueId hook

    @lychyi
    lychyi committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    2b1c98a View commit details
    Browse the repository at this point in the history

  8. chore(side-panel): Add some notes

    @lychyi
    lychyi committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    cf84d3d View commit details
    Browse the repository at this point in the history

  9. fix(side-panel): Make event handlers more specific

    @lychyi
    lychyi committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    3f4222b View commit details
    Browse the repository at this point in the history

  10. docs(side-panel): Correct jsdoc default values

    @lychyi
    lychyi committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    d5ca0f0 View commit details
    Browse the repository at this point in the history

  11. feat(side-panel): Separate state callbacks 

    Better to call cb for internal state and collapsed state separately?
    @lychyi
    lychyi committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    9d3881a View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2020

  1. test(side-panel): Init cypress tests

    @lychyi
    lychyi committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    ac4863f View commit details
    Browse the repository at this point in the history

  2. chore(side-panel): Add a note for potential bug 

    This component assumes no "force re-rendering" happens.
    @lychyi
    lychyi committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    13b746e View commit details
    Browse the repository at this point in the history

  3. chore(side-panel): Add missing deps

    @lychyi
    lychyi committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    0ad05da View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2020

  1. chore: Revert inadvertant yarn.lock changes

    @lychyi
    lychyi committed Sep 29, 2020
    Configuration menu
    Copy the full SHA
    67efbeb View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2020

  1. revert: Rollback useUniqueId changes

    @lychyi
    lychyi committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    fc2d4b7 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2020

  1. feat(side-panel): Add aria-label attr

    @lychyi
    lychyi committed Oct 2, 2020
    Configuration menu
    Copy the full SHA
    5ad218a View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2020

  1. feat(side-panel): Refactor using hooks 

    Also changed prop name from collapsed to expanded to more closely align with aria-expanded.
    @lychyi
    lychyi committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    dafa7cc View commit details
    Browse the repository at this point in the history

  2. fix(side-panel): Add type=button

    @lychyi
    lychyi committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    988348d View commit details
    Browse the repository at this point in the history

  3. chore(side-panel): Add deps for stories

    @lychyi
    lychyi committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    7f6052e View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2020

  1. Merge branch 'master' into sidepanel

    @lychyi
    lychyi committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    9a35375 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2020

  1. feat(side-panel): Add 'as' prop to specify the rendered element 

    Also refactored hooks and the stories to match.
    @lychyi
    lychyi committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    9525c73 View commit details
    Browse the repository at this point in the history

  2. docs(side-panel): Sync up docs

    @lychyi
    lychyi committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    e6c76d7 View commit details
    Browse the repository at this point in the history

  3. fix(side-panel): Remove hidden label static 

    Replace with more standard way of doing it, adjust docs
    @lychyi
    lychyi committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    ee30da8 View commit details
    Browse the repository at this point in the history

  4. docs: Remove magic section styling in storybook

    @lychyi
    lychyi committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    86543f3 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into sidepanel

    @lychyi
    lychyi committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    0f9fb80 View commit details
    Browse the repository at this point in the history

  6. chore(side-panel): Update deps

    @lychyi
    lychyi committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    33b6a8a View commit details
    Browse the repository at this point in the history

  7. docs(side-panel): Clean up stories

    @lychyi
    lychyi committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    93a4d6c View commit details
    Browse the repository at this point in the history

  8. chore: Add common module back into package.json

    @lychyi
    lychyi committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    0ddb7a1 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2020

  1. fix(side-panel): Hide header properly in story

    @lychyi
    lychyi committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    ee501ed View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2020

  1. Merge branch 'master' into sidepanel

    @lychyi
    lychyi committed Oct 17, 2020
    Configuration menu
    Copy the full SHA
    1184430 View commit details
    Browse the repository at this point in the history

  2. fix(side-panel): Require aria-label or labelled-by 

    This change actually fixes IconButtonProps, will need to address this in a separate issue.
    @lychyi
    lychyi committed Oct 17, 2020
    Configuration menu
    Copy the full SHA
    767d8ba View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2020

  1. chore: Update Cypress

    @lychyi
    lychyi committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    fe62e14 View commit details
    Browse the repository at this point in the history

  2. test(side-panel): Add Cypress tests

    @lychyi
    lychyi committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    011b172 View commit details
    Browse the repository at this point in the history

  3. fix(side-panel): Address PR comments

    @lychyi
    lychyi committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    8a50a60 View commit details
    Browse the repository at this point in the history

  4. docs(side-panel): Fix default hook example

    @lychyi
    lychyi committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    ab71869 View commit details
    Browse the repository at this point in the history

  5. chore(side-panel): Add better typings to hooks

    @lychyi
    lychyi committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    03eda56 View commit details
    Browse the repository at this point in the history

  6. test(side-panel): Add unit tests for hook

    @lychyi
    lychyi committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    42347dd View commit details
    Browse the repository at this point in the history

  7. fix(side-panel): Replace emotion styled with ours

    @lychyi
    lychyi committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    08eeea1 View commit details
    Browse the repository at this point in the history

  8. fix(side-panel): Make code more readable

    @lychyi
    lychyi committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    434f04e View commit details
    Browse the repository at this point in the history

  9. chore(side-panel): Use Record type

    @lychyi
    lychyi committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    6870461 View commit details
    Browse the repository at this point in the history

  10. test(side-panel): Fix visual tests

    @lychyi
    lychyi committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    e6c190d View commit details
    Browse the repository at this point in the history

  11. docs(side-panel): Fix readme for hooks

    @lychyi
    lychyi committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    3365528 View commit details
    Browse the repository at this point in the history

  12. chore: Add @testing-library/react-hooks dep to ignore list

    @lychyi
    lychyi committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    2482039 View commit details
    Browse the repository at this point in the history

  13. chore(side-panel): Remove unused dep

    @lychyi
    lychyi committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    8faa5c4 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'master' into sidepanel

    @lychyi
    lychyi committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    9caf331 View commit details
    Browse the repository at this point in the history

  15. Merge branch 'sidepanel' of https://github.com/lychyi/canvas-kit into… 

    … sidepanel
    @lychyi
    lychyi committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    d95ed68 View commit details
    Browse the repository at this point in the history

  16. fix(side-panel): Remove height prop, minWidth spec

    @lychyi
    lychyi committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    a949f42 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2020

  1. fix(side-panel): Switch to Plain IconButton variant

    @lychyi
    lychyi committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    b2394ac View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2020

  1. fix(side-panel): Override Plain toggle's margin

    @lychyi
    lychyi committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    689e85a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into sidepanel

    @lychyi
    lychyi committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    69a30c8 View commit details
    Browse the repository at this point in the history

  3. test(side-panel): Add aria-controls test

    @lychyi
    lychyi committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    6c21859 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'sidepanel' of https://github.com/lychyi/canvas-kit into… 

    … sidepanel
    @lychyi
    lychyi committed Nov 3, 2020
    Configuration menu
    Copy the full SHA
    118c97a View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2020

  1. test(side-panel): Remove branching logic

    @lychyi
    lychyi committed Nov 4, 2020
    Configuration menu
    Copy the full SHA
    748a80b View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2020

  1. test(side-panel): Add first focusable test

    @lychyi
    lychyi committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    5859ac4 View commit details
    Browse the repository at this point in the history