Make api version a dropdown #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made the API version a JComboBox. According to the documentation https://confluence.atlassian.com/bitbucket/use-the-bitbucket-cloud-rest-apis-222724129.html only version "1.0" and "2.0" exist.
|
I wonder if we even want to allow the API version to be changed. Particularly as we support new actions (such as approve/needs work/reactions to nested comments), we may need to use a particular API version to even make it possible. @ty1824 thoughts? |
|
Yeah - I was looking at this over the weekend, changing the API version will technically require code changes for the uptake. I think for now we can remove that option and explicitly support v1.0. |
|
Created #16 as a follow-up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the API version a JComboBox. According to the documentation
https://confluence.atlassian.com/bitbucket/use-the-bitbucket-cloud-rest-apis-222724129.html
only version "1.0" and "2.0" exist.