Add USER statement to Docker image #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kennyko
commented
Mar 27, 2019
kennyko
commented
- Refactor Dockerfile
- Remove k8s templates in favor of helm charts
* Refactor Dockerfile * Remove k8s templates in favor of helm charts
ScottBishop
suggested changes
Mar 28, 2019
| apt-get clean && \ | ||
| gem install bundler && \ | ||
| rm -f /etc/ImageMagick-6/policy.xml && \ | ||
| chown 10001:10001 /app |
There was a problem hiding this comment.
CI failed for postgres permissions
Starting [secure]_postgres_1 ...
Errno::EACCES: Permission denied @ rb_sysopen - /app/log/ci_test.log
| RUN apt-get install -y build-essential checkinstall libx11-dev libxext-dev zlib1g-dev libpng-dev libjpeg-dev libfreetype6-dev libxml2-dev nodejs | ||
|
|
||
| RUN apt-get install -y imagemagick libmagick++-dev libmagic-dev libmagickwand-dev vim libpq-dev && apt-get clean | ||
| ARG RAILS_MASTER_KEY="" |
There was a problem hiding this comment.
Why add the default string?
There was a problem hiding this comment.
Allows building the docker image without requiring the master key to be passed. It's not used anywhere during build time anyways.
ScottBishop
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.