Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change defaults #395

Closed
wants to merge 15 commits into from
Closed

Change defaults #395

wants to merge 15 commits into from

Conversation

robbecker-wf
Copy link
Member

@robbecker-wf robbecker-wf commented Jan 26, 2023 •
edited
Loading

Change the default formatter and analyzer to the newer options dart format and dart analyze

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

evanweible-wf
evanweible-wf previously approved these changes Jan 26, 2023
View reviewed changes
@robbecker-wf robbecker-wf marked this pull request as ready for review January 26, 2023 19:52
@robbecker-wf
Copy link
Member Author

QA+1 CI Passes

todbachman-wf
todbachman-wf previously approved these changes Jan 26, 2023
View reviewed changes
dustinlessard-wf
dustinlessard-wf requested changes Jan 29, 2023
View reviewed changes
Copy link

@dustinlessard-wf dustinlessard-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tests are not expecting 'analyze' to be in the buildArgs.

@robbecker-wf
Copy link
Member Author

@dustinlessard-wf Indeed. It looks like the analyze args are different depending on if you are using "dart analyze" mode vs "dartanalyzer" mode. Instead of fixing the tests, I think I'll investigate changing the code so that the analyzer args are the same no matter which mode you are in.

@robbecker-wf robbecker-wf added the Hold Hold merges label Jan 30, 2023
@robbecker-wf robbecker-wf deleted the change_default_formatter branch January 31, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustinlessard-wf dustinlessard-wf dustinlessard-wf requested changes

@evanweible-wf evanweible-wf evanweible-wf left review comments

@todbachman-wf todbachman-wf todbachman-wf left review comments

Assignees
No one assigned
Labels
Hold Hold merges Merge Requirements Unmet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@robbecker-wf @aviary2-wf @evanweible-wf @dustinlessard-wf @todbachman-wf @rmconsole-wf