Turn off implicit-casts and implicit-dynamic #5
Conversation
RavenNumber of Findings: 0 |
| Set<String> get devDependencies => | ||
| ((_yamlMap[_devDependenciesKey] as YamlMap ?? const <dynamic, dynamic>{}).keys as Iterable<String>).toSet() | ||
| // Remove this package, since we know they're using our executable | ||
| ..remove(_dependencyValidatorPackageName); |
There was a problem hiding this comment.
Filtering out the dependency_validator package from the dev deps seems like it should happen elsewhere, since this is just a generic PubspecYaml class to help parse a pubspec.yaml file.
There was a problem hiding this comment.
Hmm, I meant this class to be specific to this use-case. That's why I made it private. I can rename it if you'd like
There was a problem hiding this comment.
yeah I guess it's private so it's not a big deal
| ..remove(_dependencyValidatorPackageName); | ||
|
|
||
| Set<String> get packagesUsedViaTransformers { | ||
| final transformerEntries = _yamlMap[_transformersKey] as Iterable<Object>; |
There was a problem hiding this comment.
Similarly, this seems to me like it should expose the transformer configurations in a typed manner, and then a separate utility function could take a PubspecYaml instance as input and return the package names
|
Will re-open when this is more important / when Dart 2 comes out. |
Ultimate Problem
This will be how Dart 2 operates, might as well follow those guidelines
Solution
implicit-castsandimplicit-dynamicTesting Suggestions
Possible Areas of Regression
Everything
FYA: @evanweible-wf