Add parent id and request id to Async #147
Conversation
Add a parent id and request id to the Async object. The parent id will be passed down to "children" asyncs. This will allow us to track the chain/graph of asyncs without developer intervention.
|
|
||
| @property | ||
| def _function_path(self): | ||
| # DEPRECATED: Hanging around for backwards compatibility. | ||
| return self.job[0] |
There was a problem hiding this comment.
Would it make sense to have this wrap self.function_path, so their implementations don't get out of sync? Just in case we ever change the behavior of job.
There was a problem hiding this comment.
Yep. Will change.
There was a problem hiding this comment.
It's unclear to me why this needs to change. Is the intention to make function_path part of the public-facing API?
There was a problem hiding this comment.
@tylertreat-wf . Yes. It's already being accessed by non-internal consumers. Hence the reason I'm having to leave the old method around (I broke some user's of Furious code when doing some integration testing)
Better handling of deprecated function to ensure backwards compatibility.
| return self.job[0] | ||
|
|
||
| @property | ||
| def _function_path(self): | ||
| # DEPRECATED: Hanging around for backwards compatibility. | ||
| return self.function_path() |
There was a problem hiding this comment.
function_path is a property, not callable.
function_path is a property not a method so don't parens is :)
|
@robertkluin-wf @tannermiller-wf @tylertreat-wf @rosshendrickson-wf @johnlockwood-wf PR Updated |
|
+1 |
1 similar comment
|
+1 |
Add parent id and request id to Async
Add a parent id and request id to the Async object. The parent id will be passed
down to "children" asyncs. This will allow us to track the chain/graph of asyncs
without developer intervention.
@robertkluin-wf @tannermiller-wf @tylertreat-wf @rosshendrickson-wf @johnlockwood-wf