Skip to content
This repository has been archived by the owner on Apr 30, 2024. It is now read-only.

Inherit Queue for completion check #157

Merged
merged 11 commits into from
Oct 24, 2014

Conversation

rosshendrickson-wf
Copy link
Contributor

Addresses concerns over completion checks and cleanup tasks occurring in the default queue in BigSky.

Three configurable options were added

cleanupqueue - where cleanup tasks for completion markers should be run
cleanupdelay - how long should cleanup tasks be delayed
defaultqueue - what is the default queue for completion and cleanup tasks (if no cleanupqueue is defined)

Completion checks will now inherit which queue they will run in from the tasks that kick them off. There is a new example of how this works added to the examples folder called context_inherit.

This pattern of inheritance allows greater freedom to shard async's across different queues and balance out their own performance (completion performance included).

@beaulyddon-wf @tylertreat @tannermiller-wf @johnlockwood-wf

@tylertreat-wf
Copy link
Contributor

+1

3 similar comments
@tannermiller-wf
Copy link
Contributor

+1

@beaulyddon-wf
Copy link
Contributor

+1

@johnlockwood-wf
Copy link
Contributor

+1

beaulyddon-wf added a commit that referenced this pull request Oct 24, 2014
Inherit Queue for completion check
@beaulyddon-wf beaulyddon-wf merged commit 8218854 into Workiva:master Oct 24, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants