This repository has been archived by the owner on Apr 30, 2024. It is now read-only.
Trigger error handler on DeadlineExceededError #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t inherit from BaseException (such as google.appengine.runtime.DeadlineExceededError) instead of Exception
|
+1 |
1 similar comment
|
+1 |
| @@ -67,7 +67,7 @@ def run_job(): | |||
| except AbortAndRestart as restart: | |||
| logging.info('Async job was aborted and restarted: %r', restart) | |||
| raise | |||
| except Exception as e: | |||
| except BaseException as e: | |||
There was a problem hiding this comment.
Hmm, so Google is inheriting from BaseException instead of Exception?
That's not cool. https://docs.python.org/2/library/exceptions.html#exceptions.BaseException
There was a problem hiding this comment.
Should someone follow up with Google?
There was a problem hiding this comment.
Was this followed up on and do we wish to investigate?
There was a problem hiding this comment.
The docs show that google.appengine.runtime.DeadlineExceededError inherits from BaseException:
https://code.google.com/p/googleappengine/source/browse/trunk/python/google/appengine/runtime/__init__.py
Also of note is the try/except block.
|
+1 |
beaulyddon-wf
added a commit
that referenced
this pull request
Feb 5, 2016
…ling Trigger error handler on DeadlineExceededError
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @beaulyddon-wf @macleodbroad-wf @erikpetersen-wf
O: @jasonaguilon-wf @rosshendrickson-wf @tylertreat-wf
We will now trigger the failure handler from any exception that inherits from BaseException (such as google.appengine.runtime.DeadlineExceededError) instead of Exception.