AF-361: Adds top level react_wrappers lib and removes test_util.react_util lib #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on HipChat: InfoSec Forum. |
kealjones-wk
changed the title
Codecov Report
@@ Coverage Diff @@
## master #168 +/- ##
=======================================
Coverage 94.45% 94.45%
=======================================
Files 34 34
Lines 1601 1601
=======================================
Hits 1512 1512
Misses 89 89 |
clairesarsam-wf
approved these changes
Jul 17, 2018
|
QA +1
Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AF-361
Ultimate problem:
Make react_wrappers.dart a top-level lib
How it was fixed:
Created a
react_wrappers.dartfile as a top level library file exportingpackage:over_react/src/util/react_wrappers.dartTesting suggestions:
None.
Potential areas of regression:
library test_util.react_util no longer exists.