Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPLAT-4749 Release over_react 1.32.0 #262

Merged
merged 17 commits into from
Mar 8, 2019

Conversation

greglittlefield-wf
Copy link
Contributor

Backpatch of #249 into the Dart 1.x line so that consumers get warnings without having to wait until they switch to Dart 2.

@greglittlefield-wf greglittlefield-wf requested a review from a team as a code owner March 5, 2019 22:44
@greglittlefield-wf greglittlefield-wf changed the title Backpatch map warnings Release over_react 1.32.0 Mar 5, 2019
@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@greglittlefield-wf greglittlefield-wf changed the title Release over_react 1.32.0 CPLAT-4749 Release over_react 1.32.0 Mar 5, 2019
Copy link
Contributor

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov-io
Copy link

Codecov Report

Merging #262 into 1.31.0_release_base will increase coverage by 0.05%.
The diff coverage is 100%.

@@                   Coverage Diff                   @@
##           1.31.0_release_base     #262      +/-   ##
=======================================================
+ Coverage                90.24%   90.28%   +0.05%     
=======================================================
  Files                       35       35              
  Lines                     1771     1779       +8     
=======================================================
+ Hits                      1598     1606       +8     
  Misses                     173      173

Copy link
Contributor

@kealjones-wk kealjones-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA +1

@Workiva/release-management-pp

@rmconsole6-wk rmconsole6-wk merged commit 5facba5 into 1.31.0_release_base Mar 8, 2019
@rmconsole6-wk rmconsole6-wk deleted the backpatch_map_warnings branch March 8, 2019 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants