CPLAT-6287: Promote missing over_react part to severe log (fail the build) #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanweible-wf
requested review from
corwinsheahan-wf,
aaronlademann-wf and
greglittlefield-wf
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
evanweible-wf
added a commit
that referenced
this pull request
Jul 2, 2019
This will cause the build to fail, which is a breaking change as previously the builder would only warn. This change is being made because the part directive is required to function correctly on Dart 2 (without it, the component will fail at runtime). In other words, we are promoting the failure from runtime to buildtime.
evanweible-wf
force-pushed
the
promote_missing_part_to_severe
branch
from
412bdcd
to
c330c63
Compare
rmconsole3-wf
changed the title
charliekump-wf
changed the title
corwinsheahan-wf
approved these changes
Jul 2, 2019
todbachman-wf
approved these changes
Jul 8, 2019
|
QA +1
@Workiva/release-management-p |
kealjones-wk
added a commit
that referenced
this pull request
Aug 6, 2019
* 3.0.0-wip: Address CR feedback Point to published version of react Add support for SyntheticAnimationEvent / SyntheticTransitionEvent Backport type loosening of DomProps.componentFactory in 3.1.0-wip, since it could break some usages Avoid shadowing `type` argument Improve error message for props/state variables with initializers Changelog entry for #314. Promote missing over_react part to a SEVERE log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CPLAT-6287
This is a breaking change and has been PR'd to the 3.0.0 wip branch.
Motivation
The generated
.over_react.g.dartpart file is required for components to function on Dart2. Currently, the builder only logs a warning when the part file is missing, which could lead to a scenario where a consumer omits the part, ignores or doesn't see the warning, and runs into a runtime exception. It would be better to promote this error to one that fails the build so that it can be fixed immediately.Changes
This PR promotes the log for the missing over_react part to the
SEVERElevel, which in turn causes the build to fail. In other words, this failure is being promoted from a runtime error to a build-time error.Changes
Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: