Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPLAT-7471 Refactor Prop Type Tests #433

Merged
merged 10 commits into from
Dec 12, 2019
Merged

CPLAT-7471 Refactor Prop Type Tests #433

merged 10 commits into from
Dec 12, 2019

Conversation

joebingham-wk
Copy link
Contributor

Motivation

The prop type tests for over_react were still using the outdated propType testing methods. Refactoring the tests keeps them up to date with the latest APIs and helps provide examples of how to use our testing utils.

Changes

  • Refactor any test the tests propTypes

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:
@kealjones-wk @greglittlefield-wf @sydneyjodon-wk @aaronlademann-wf

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

aaronlademann-wf
aaronlademann-wf requested changes Dec 3, 2019
View reviewed changes
...ration/builder_integration_tests/component2/constant_required_accessor_integration_test.dart Outdated Show resolved Hide resolved
...ration/builder_integration_tests/component2/constant_required_accessor_integration_test.dart Outdated Show resolved Hide resolved
...ration/builder_integration_tests/component2/constant_required_accessor_integration_test.dart Outdated Show resolved Hide resolved
...ration/builder_integration_tests/component2/constant_required_accessor_integration_test.dart Outdated Show resolved Hide resolved
...ration/builder_integration_tests/component2/constant_required_accessor_integration_test.dart Outdated Show resolved Hide resolved
...ration/builder_integration_tests/component2/constant_required_accessor_integration_test.dart Outdated Show resolved Hide resolved
...ent_declaration/builder_integration_tests/component2/required_accessor_integration_test.dart Show resolved Hide resolved
greglittlefield-wf
greglittlefield-wf requested changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, otherwise just formatting nits.

I love these matchers so much 😻

pubspec.yaml Show resolved Hide resolved
...ration/builder_integration_tests/component2/constant_required_accessor_integration_test.dart Outdated Show resolved Hide resolved
...ration/builder_integration_tests/component2/constant_required_accessor_integration_test.dart Outdated Show resolved Hide resolved
...ration/builder_integration_tests/component2/constant_required_accessor_integration_test.dart Outdated Show resolved Hide resolved
...ration/builder_integration_tests/component2/constant_required_accessor_integration_test.dart Outdated Show resolved Hide resolved
...ent_declaration/builder_integration_tests/component2/required_accessor_integration_test.dart Outdated Show resolved Hide resolved
...ent_declaration/builder_integration_tests/component2/required_accessor_integration_test.dart Outdated Show resolved Hide resolved
...ent_declaration/builder_integration_tests/component2/required_accessor_integration_test.dart Outdated Show resolved Hide resolved
...ent_declaration/builder_integration_tests/component2/required_accessor_integration_test.dart Outdated Show resolved Hide resolved
joebingham-wk and others added 4 commits December 3, 2019 16:29
@joebingham-wk @greglittlefield-wf
Apply suggestions from code review
32ad8a7 
Co-Authored-By: Greg Littlefield <greg.littlefield@workiva.com>
@joebingham-wk @greglittlefield-wf
Update test/over_react/component_declaration/builder_integration_test…
e366222 
…s/component2/required_accessor_integration_test.dart

Co-Authored-By: Greg Littlefield <greg.littlefield@workiva.com>
@joebingham-wk
Add comment
df41e36
@joebingham-wk
Merge branch 'CPLAT-7471-refactor-propType-tests' of github.com:Worki…
12ea74c 
…va/over_react into CPLAT-7471-refactor-propType-tests
aaronlademann-wf
aaronlademann-wf approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Nice work here @joebingham-wk !!!

greglittlefield-wf
greglittlefield-wf approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

@Workiva/release-management-p

@rmconsole4-wk rmconsole4-wk merged commit 3cb8efd into master Dec 12, 2019
@rmconsole4-wk rmconsole4-wk deleted the CPLAT-7471-refactor-propType-tests branch December 12, 2019 16:26
@aaronlademann-wf aaronlademann-wf mentioned this pull request Dec 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greglittlefield-wf greglittlefield-wf greglittlefield-wf approved these changes

@aaronlademann-wf aaronlademann-wf aaronlademann-wf approved these changes

Assignees
No one assigned
Labels
Merge Requirements Met RM Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@joebingham-wk @aviary2-wf @greglittlefield-wf @aaronlademann-wf @rmconsole-wf @rmconsole4-wk