Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FED-2443 Merge version 5.0.0 changes to master #898

Merged
merged 611 commits into from
Mar 26, 2024
Merged

FED-2443 Merge version 5.0.0 changes to master #898

merged 611 commits into from
Mar 26, 2024

Conversation

aaronlademann-wf
Copy link
Contributor

As a first step to releasing version 5.0.0 of this library, we need to:

  1. Update the changelog to include information about the 5.0.0 release.
  2. Temporarily point to the unreleased 3.0.0 changes in master of over_react_test.
  3. Merge the changes from the v5_wip branch into master without actually tagging it as a release.

greglittlefield-wf and others added 30 commits December 18, 2023 17:17
@greglittlefield-wf
Add more efficient AnalyzerDebugHelper method
6d013bf
@greglittlefield-wf
Reenable plugin, different codes based on late/annotation, respect ig…
0ef53e8 
…nores
@greglittlefield-wf
Add some tests for getAllProps, respect Accessor(doNotGenerate: true)
1f0f7d5
@greglittlefield-wf
First stab at supporting legacy props classes in getAllProps
ab3657a
@greglittlefield-wf
Optimize required prop diagnostic
8508cd4
@greglittlefield-wf
Display the top 3 slowest diagnostics in the metrics info
609d030
@greglittlefield-wf
Collect timings on shared getAllComponentUsages call
fe79396
@greglittlefield-wf
Cache required prop info, optimize missing prop check
efdc268
@sydneyjodon-wk
Fix last exhaustive deps test case
dcd18a1
@sydneyjodon-wk
Fix invalid child diagnostic and add tests
9970e0a
@sydneyjodon-wk
Update playground demos
3bf1ab0
@sydneyjodon-wk
Clean up
a740110
@sydneyjodon-wk
Update ref related assists to output nullable type
d26144c
@sydneyjodon-wk
Remove analyzer plugin check for 2.18.7
4f20e51
@greglittlefield-wf
Include source props clas in message
4399eaf
@greglittlefield-wf
Merge pull request #869 from Workiva/null-safety-required-props
31940a6 
FED-1717 Finalize null-safe props/state implementation and utilities, add tests
@greglittlefield-wf
Work around InconsistentAnalysisException when computing fixes
71ea105
@greglittlefield-wf
Fix incorrect typing
705eba9
@greglittlefield-wf
Merge remote-tracking branch 'origin/analyzer_plugin_null_safety' int…
df59d0c 
…o required-props-lint
@greglittlefield-wf
Clean up getAllProps and its usages
87cd066
@greglittlefield-wf
Add test cases for subclasses
11d9b6e
@greglittlefield-wf
Add some more getAllProps test cases
abd83ce
@greglittlefield-wf
Add some tests, fix builder variables being linted
6798983
@greglittlefield-wf
Add tests for @requiredProp props
babd8f1
@greglittlefield-wf
Add test for inherited props
2c0e8b3
@greglittlefield-wf
Update playground example
3b67fa8
@greglittlefield-wf
Add test case for potential name conflicts with prefixed props
0a85ca5
@greglittlefield-wf
Make return types more specific so that matcher extensions can be used
3cc05a9
@greglittlefield-wf
Assert fix missage
0ce099a
@greglittlefield-wf
Add test for generic factory
9f086fc
greglittlefield-wf
greglittlefield-wf reviewed Mar 26, 2024
View reviewed changes
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple comments on the changelog, and made it partially through the full diff. Will continue reviewing tomorrow!

lib/src/builder/codegen/accessors_generator.dart Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@aaronlademann-wf @greglittlefield-wf
Apply suggestions from code review
af4939d 
Co-authored-by: Greg Littlefield <greg.littlefield@workiva.com>
greglittlefield-wf
greglittlefield-wf requested changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished doing an additional pass on all the changes in lib!

Just spotted a couple things, and also noted some things missing from the changelog that I can push up or PR

lib/src/over_react_redux/over_react_flux.dart Show resolved Hide resolved
pubspec.yaml Outdated Show resolved Hide resolved
@aaronlademann-wf @greglittlefield-wf
Apply suggestions from code review
b42e4e4 
Co-authored-by: Greg Littlefield <greg.littlefield@workiva.com>
greglittlefield-wf
greglittlefield-wf approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Changelog looks good
  • Re-reviewed all changes in lib and pubspec.yaml and they look good
  • Almost all commits in this branch have been reviewed and tested in PRs into v5_wip, and other commits look good
  • CI passes
  • This branch has been recently tested in consumers

+10

@greglittlefield-wf
Copy link
Contributor

semver +1

sydneyjodon-wk
sydneyjodon-wk approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@sydneyjodon-wk sydneyjodon-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on Greg's most recent commits

@dancleereman-wf
Copy link
Contributor

RM +1

@dancleereman-wf dancleereman-wf merged commit cefdbda into master Mar 26, 2024
8 of 9 checks passed
@rmconsole-readonly-wk rmconsole-readonly-wk mentioned this pull request Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greglittlefield-wf greglittlefield-wf greglittlefield-wf approved these changes

@sydneyjodon-wk sydneyjodon-wk sydneyjodon-wk approved these changes

Assignees
No one assigned
Labels
Merge Requirements Met semver: Major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aaronlademann-wf @aviary2-wf @greglittlefield-wf @dancleereman-wf @sydneyjodon-wk @rmconsole-wf