Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prop error message #92

Conversation

jacehensley-wf
Copy link
Contributor

@jacehensley-wf jacehensley-wf commented Jun 30, 2017

Related to: Workiva/over_react_test#8

Ultimate problem:

When running tests in the DDC the Error.safeToString was kinda a PITA

How it was fixed:

  • Do not use Error.safeToString

Testing suggestions:

??

Potential areas of regression:

N/A


FYA: @greglittlefield-wf @aaronlademann-wf @jacehensley-wf @clairesarsam-wf @joelleibow-wf

@aviary-wf
Copy link

Raven

Number of Findings: 0

@aaronlademann-wf
Copy link
Contributor

+1

@clairesarsam-wf
Copy link
Contributor

+1

@aaronlademann-wf
Copy link
Contributor

QA +1

  • Testing instruction
  • Dev +1's
  • Dev/QA +10
  • Unit tests created/updated
  • All unit tests pass
    • Unit test failure is a result of a dependency not having merged yet, and that dependency not being able to merge without this PR merging first.
    • I verified that the failure it causes is isolated to the test - does not effect lib/ code at all.
  • Rosie ran/Rosie comment displays expected info
  • Dependency Scan Clean

Merging.

@aaronlademann-wf aaronlademann-wf merged commit d462277 into Workiva:master Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants