Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG for 2.1.1 Release #54

Merged
merged 2 commits into from
Oct 21, 2022
Merged

Update CHANGELOG for 2.1.1 Release #54

merged 2 commits into from
Oct 21, 2022

Conversation

kealjones-wk
Copy link
Contributor

Motivation

  • Needed to update the changelog to include latest stuff before release

Changes

  • Updated the changelog

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Frontend Frameworks Design member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@kealjones-wk kealjones-wk requested review from a team and greglittlefield-wf and removed request for a team October 21, 2022 21:52
@kealjones-wk kealjones-wk changed the title Update CHANGELOG for v2.1.1 Release Update CHANGELOG for 2.1.1 Release Oct 21, 2022
Copy link
Contributor

@sydneyjodon-wk sydneyjodon-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@kealjones-wk
Copy link
Contributor Author

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole4-wk rmconsole4-wk merged commit 90dffc9 into master Oct 21, 2022
@rmconsole4-wk rmconsole4-wk deleted the changelog-2.1.1 branch October 21, 2022 22:30
* [#53](https://github.com/Workiva/react_testing_library/pull/53) Remove a CI check that was no longer working properly
* [#52](https://github.com/Workiva/react_testing_library/pull/52) Fix missing arguments in formatted output from forwarded console logs
* [#51](https://github.com/Workiva/react_testing_library/pull/51) Update references to the previous team name with Frontend Frameworks Design
* [#49](https://github.com/Workiva/react_testing_library/pull/49) Add changelog for 2.1.0 release, add de-facto skynet plan -
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this changelog!

#nit, changes like changelog updates and most CI cganges don't impact consumers and IMO make the changelog noisy, so in the future we can omit those

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants