Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dart 2.19 #35

Merged
merged 5 commits into from Oct 30, 2023
Merged

Dart 2.19 #35

merged 5 commits into from Oct 30, 2023

Conversation

sourcegraph-wk
Copy link

Summary

This batch updates CI to use Dart 2.19. In most cases, updating Just Works™,
but here's some things that have changed or may cause problems while updating.

  • The pub and dart2js aliases have been removed. You may need to replace bare pub commands. See the replacements here https://wiki.atl.workiva.net/display/CP/Dart+2.18+FAQ
  • There may be some new lints, or lints that actually function better and now find new issues that need fixing or ignoring.
  • Some lints may have been raised to warnings that now need fixing or ignoring until fixed.
  • Dockerfiles or skynet may try to install things that don't work quite right on newer debian 11 (bullseye)
    • Potential examples are installing python or nodejs into the dart images
  • If you have build.yaml files that "split" the builders into separate targets, you may have to exclude a new builder
  build_resolvers|transitive_digests:
    enabled: false

These PRs are ok to get reviewed and approved.
If it is out of draft and there isn't a `Hold`` label, then it is ok to merge.

For support go to #support-frontend-dx in Slack.

Created by Sourcegraph batch change Workiva/dart_2_19.

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@robbecker-wf robbecker-wf marked this pull request as ready for review October 28, 2023 22:13
@todbachman-wf
Copy link
Member

QA +1. @Workiva/release-management-pp

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole5-wk rmconsole5-wk merged commit e272849 into master Oct 30, 2023
6 checks passed
@rmconsole5-wk rmconsole5-wk deleted the batch/fedx/dart_2_19 branch October 30, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants