S174 : more cleanup #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlorper
approved these changes
May 17, 2024
| throw new IOException("Exception while deserilaizing.", e); | ||
| public static Object deserialize(byte[] data) throws IOException, ClassNotFoundException { | ||
| // Attempt to decompress | ||
| try (ByteArrayInputStream byteIn = new ByteArrayInputStream(data); |
There was a problem hiding this comment.
could do something like this to avoid the error check
https://github.com/Worklytics/evalengin/blob/c3a95665c4a75a5452cc1aaf8bbed5a44aa4ad1d/worklytics-common/src/main/java/com/engetc/util/CompressionUtils.java#L41
| try (ObjectOutputStream objectOut = new ObjectOutputStream(byteOut)) { | ||
| objectOut.writeObject(obj); | ||
| } | ||
| byte[] serializedData = byteOut.toByteArray(); |
There was a problem hiding this comment.
just ask for the size byteOut.size(), doing toByteArray is copying the object into a new array, so consuming x2 memory if it happens to be big.
if (byteOut.size() > MAX) {
// compress
} else {
// return as is
return byteou.toByteArray();
}
aperez-worklytics
approved these changes
May 20, 2024
| public static void inject(String moduleClassFQN, Object injectable) { | ||
| ObjectGraph objectGraph = getFromModuleClass(moduleClassFQN); | ||
| objectGraph.inject(injectable); | ||
| public static void inject(Class<?> componentClass, Object injectable) { |
There was a problem hiding this comment.
Why not
Suggested change
| public static void inject(Class<?> componentClass, Object injectable) { | |
| public static void inject(Class<?> componentClass, Injectable injectable) { |
?
So it can fails on compile time ?
There was a problem hiding this comment.
Injectable is an annotation .. but yeah, will refactor to make things cleaer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Change implications