drop basic exec policy from caller role

[eschultink]

Fixes

• lambda basic exec role is effectively just logging perms, not needed - as lambdas have their own exec rules with those perms

Change implications

• dependencies added/changed? no
• something important to note in future release notes? yes - will see role attachment being destroyed

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1206355928380269

[jlorper]

Are you sure this works? Do lambdas log because they have the rights to do so, or because the caller (that can do InvokeURL) also has logging permissions?
Also this policy is mentioned in various doc files, see https://github.com/search?q=repo%3AWorklytics%2Fpsoxy%20AWSLambdaBasicExecutionRole&type=code . Does it need to be dropped in certain cases?

[eschultink]

lambdas don't execute as this role

they each have their own execution role; and the lambda execution permission is attached to each here:

psoxy/infra/modules/aws-psoxy-lambda/main.tf

Line 140 in 02b8dc5

resource "aws_iam_role_policy_attachment" "basic" {

[jlorper]

got it. Looks good then