add support for user-defined POS for all OOV handlers #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the feature is gated by userPos flag of OOV handlers, which must be set to true for this feature to work
eiennohito
force-pushed
the
feature/arseny/beta1-fixes
branch
from
7380970
to
229e3c3
Compare
|
enforce も試しに実装してみたのですが、ややこしくなったので、断念しました。 |
kazuma-t
requested changes
Jun 6, 2022
src/main/java/com/worksap/nlp/sudachi/MeCabOovProviderPlugin.java
Outdated
Show resolved
Hide resolved
src/main/java/com/worksap/nlp/sudachi/MeCabOovProviderPlugin.java
Outdated
Show resolved
Hide resolved
and refer to it from all locations also, make naming more consistent
eiennohito
force-pushed
the
feature/arseny/beta1-fixes
branch
from
bfe2db8
to
86eac82
Compare
kazuma-t
requested changes
Jun 7, 2022
|
Kudos, SonarCloud Quality Gate passed! |
kazuma-t
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #185
the feature is gated by userPos flag of OOV handlers,
which must be set to true for this feature to work