Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add equals and hashcode to config class #192

Merged
merged 1 commit into from
Jun 23, 2022
Merged

add equals and hashcode to config class #192

merged 1 commit into from
Jun 23, 2022

Conversation

eiennohito
Copy link
Collaborator

No description provided.

@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

53.0% 53.0% Coverage
0.0% 0.0% Duplication

@eiennohito eiennohito requested a review from kazuma-t June 23, 2022 00:59
@eiennohito
Copy link
Collaborator Author

Coverage fails, but covering autogenerated hashCode is not a useful exercise in my opinion.

@eiennohito eiennohito merged commit b180a4d into develop Jun 23, 2022
@eiennohito eiennohito deleted the feature/arseny/config-hashcode-equals branch June 23, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazuma-t kazuma-t kazuma-t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eiennohito @kazuma-t