Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MorphemeList.splittedWith method #195

Merged
merged 3 commits into from
Jul 27, 2022
Merged

Conversation

eiennohito
Copy link
Collaborator

@eiennohito eiennohito commented Jul 26, 2022

  1. Make all tokenizing methods return concrete MorphemeList instead of List
  2. Add new MorphemeList.split API which resplits already-splitted MorphemeList with different analysis mode. Making more fine analysis from more coarse analysis is supported, going back is not.
  3. Refactor splitting logic to remove duplicated code.

If there are better ideas on the name of this method, I would be happy to hear them.

@eiennohito eiennohito requested a review from kazuma-t July 26, 2022 02:03
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

92.1% 92.1% Coverage
0.0% 0.0% Duplication

@eiennohito eiennohito merged commit f91ab0c into develop Jul 27, 2022
@eiennohito eiennohito deleted the feature/arseny/split-list branch August 16, 2022 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants