Disable MorphemeConsumerAttribute (+bug fix) #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This will also fix #117, where synonym filter doesn't work correctly with empty term attibure caused by MCA. |
kazuma-t
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #111, fix #116. relates to #110
Disable MorphemeConsumerAttribute.
MorphemeConsumerAttribute (MCA) suggests which sudachi-filter should set the CharTermAttribute. Only the last filter with MCA sets it.
This makes CharTermAtt empty until the last filter, thus filters like stopword-filter or synonym-filter that use termAtt doesn't work correctly when there is a filter with MCA after it.
We need to consider how MCA should behave, but for now I disabled it.
Fix MorphemeAttribute.copyTo.
copyTo method should copy current state into target attribute.
Fix POSFilter with null morpheme.
Morpheme attribute may have null morpheme (e.g. token added by synonym filter).
POSFilter should work in that case too, accepting them since no pos is available.