Feature/fix minification #103
Conversation
Look for all assets, not just one directory down.
| @@ -13,7 +13,7 @@ server { | |||
| proxy_set_header X-Forwarded-Server $host; | |||
| proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for; | |||
|
|
|||
| try_files $uri $uri/ /index.html; | |||
There was a problem hiding this comment.
Do all the app pages still work with this change? After replying to #84 I was told that a fallback to /index.html is required when html5mode = true in order to allow Angular to handle routing paths that nginx can't find. I'd love it if that weren't true though since I think that recursively redirecting forever is a poor substitute for 404s.
There was a problem hiding this comment.
I've tried clicking around everything in the web app, and it seems fine. Not sure if there's maybe some other browsers/configurations that might not work with this.
There was a problem hiding this comment.
It it curious that /#!/ gets inserted in all the routes. Page reloads seem fine though.
|
+1 -- should probably also open an issue for minifying / concatenating partials. |
Feature/fix minification
Fixes grunt production task, so web app will run in production from
buildtask.Closes #55.
Although this makes partials available again, they are not minified or concatenated. It might be better to reinstate the
ngtemplatestask removed in #55 to serve the partials more efficiently.Also fixes issues with Leaflet image references.