Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcile differences in production.j2 and production.example #760

Merged
merged 1 commit into from Mar 12, 2019

Conversation

rmartz
Copy link
Contributor

@rmartz rmartz commented Mar 7, 2019

Overview

Over time, a small number changes have been made to either production.example but not production.j2 or vise versa. This confuses which one should be used, which is a significant impediment when creating a new instance or performing an instance upgrade.

This applies observed changes to the corresponding file, so the only differences should be differences of value.

Checklist

  • PR has a descriptive enough title to be useful in changelogs

Testing Instructions

  • Run
diff deployment/ansible/group_vars/production.{j2,example}
  • The only differences should be variable value templating and {% raw %}/{% endraw %}

@@ -22,6 +22,7 @@ app_version: "0.0.0"
app_domain_name: "your.driver-domain.here"

## DOCKER SETTINGS
docker_image_tag: "{{app_version}}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like something that might fit in the ADVANCED section at the bottom, since it's just a reassignment of an already provided value that I suspect the user won't need to set themselves, like what we do with allowed_host:

####################################
# ADVANCED #
####################################
allowed_host: "{{ app_domain_name }}"

@rmartz rmartz merged commit cb1aa36 into develop Mar 12, 2019
@rmartz rmartz deleted the bugfix/diverged-production-group_vars branch March 12, 2019 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants