-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/edit constant fields #87
Feature/edit constant fields #87
Conversation
We will probably want to use something else for a date/time picker. This is one of only two Bootstrap date pickers with a time components, which is why I'm using it here. (The other option is less suitable.) The Angular adapter for it does not expose a way to dynamically update the options, so it's not currently possible to change the valid min/max date based on the other picker's value. The Angular adapter also does not recognize click events on the calendar icon, though the base library does. Also, @jbranigan does not like the UI of its time component (it has been used in another project). |
function onSaveClicked() { | ||
if (ctl.editor.errors.length > 0) { | ||
// set geom array back on record | ||
ctl.record.geom.coordinates = [ctl.geom.lat, ctl.geom.lng]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work when adding a new record, because the geom object won't yet be defined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call.
+1 after addressing my comments. Looks good. |
The task this addresses is for adding the interface to edit the existing constant fields, not modifying what those are. Perhaps it would make more sense to address those changes here and to Ashlar separately. |
Sure, that works. I'll add a couple issues. |
Feature/edit constant fields
Adds area to the head of the record edit form for the constant record fields: slug, label, geom, and occurred from/to.