Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/edit constant fields #87

Conversation

flibbertigibbet
Copy link
Contributor

Adds area to the head of the record edit form for the constant record fields: slug, label, geom, and occurred from/to.

image

@flibbertigibbet
Copy link
Contributor Author

We will probably want to use something else for a date/time picker. This is one of only two Bootstrap date pickers with a time components, which is why I'm using it here. (The other option is less suitable.)

The Angular adapter for it does not expose a way to dynamically update the options, so it's not currently possible to change the valid min/max date based on the other picker's value. The Angular adapter also does not recognize click events on the calendar icon, though the base library does. Also, @jbranigan does not like the UI of its time component (it has been used in another project).

function onSaveClicked() {
if (ctl.editor.errors.length > 0) {
// set geom array back on record
ctl.record.geom.coordinates = [ctl.geom.lat, ctl.geom.lng];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work when adding a new record, because the geom object won't yet be defined.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call.

@kshepard
Copy link
Member

+1 after addressing my comments. Looks good.

@flibbertigibbet
Copy link
Contributor Author

The task this addresses is for adding the interface to edit the existing constant fields, not modifying what those are. Perhaps it would make more sense to address those changes here and to Ashlar separately.

@kshepard
Copy link
Member

Sure, that works. I'll add a couple issues.

flibbertigibbet added a commit that referenced this pull request Aug 27, 2015
@flibbertigibbet flibbertigibbet merged commit 0ad60fc into WorldBank-Transport:develop Aug 27, 2015
@flibbertigibbet flibbertigibbet deleted the feature/edit-constant-fields branch August 27, 2015 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants