Add travel time performance indicator #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| .toMap | ||
| } | ||
| /*new ObservedStopTimes { |
|
+1 could probably use another set of eyes though. |
| object ObservedStopTimes { | ||
| def apply(scheduledSystems: Map[SamplePeriod, TransitSystem])(implicit session: Session): ObservedStopTimes = { | ||
| // This is ugly: a thousand sorries. it also is apparently necessary - | ||
| // we have to index on SamplePeriod and again on trip id |
There was a problem hiding this comment.
I'm not sure that it's necessary to have the trips divided up by SamplePeriod; trip ids are supposed to be unique, so I think that a Map[String, Trip] would be sufficient here. That might simplify things; it would allow params.observedForTrip(period, trip.id) below to become something like params.observedTrips[trip.id]. I might be missing something though.
moradology
force-pushed
the
feature/traveltime-performance
branch
from
28e1e9f
to
5b47687
Compare
moradology
added a commit
that referenced
this pull request
Oct 13, 2014
Add travel time performance indicator - creating issue for exploration of a simpler map from trip ID to observed 'real-time' trip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit includes indicator calculation parameter additions which make possible the use of observed data as well as the 'on time performance' indicator/tests.