Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rah export #227

Merged
merged 10 commits into from
Sep 7, 2018
Merged

Rah export #227

merged 10 commits into from
Sep 7, 2018

Conversation

danielfdsilva
Copy link
Collaborator

@danielfdsilva danielfdsilva commented Jun 26, 2018

Adds the api endpoint to export project results to the RAH repository.

Todo:

  • Add unique instance id to avoid conflicts if multiple instances publish to the same RAH repo.

To consider:

  • At this moment if a user tries to export results for a project which still has to be merged the export will be rejected. This prevents multiple exports with the exact same data from being created but rises a potential problem. If when the PR is merged and the branch is not deleted it will prevent the project from being exported again since this check depends on the branch existence. Thoughts @olafveerman ?

@danielfdsilva
Copy link
Collaborator Author

@olafveerman To solve the "to consider" situation we could add to the guide that the branch must be deleted after the PR is merged.

@olafveerman
Copy link
Contributor

olafveerman commented Sep 6, 2018

This looks great @danielfdsilva.

Things we should do before merging:

  • handle the failing test
  • add some documentation in the Readme about the feature. What it does, pointing to the RAH repo.

We should also document this in the RAM deployment repo: https://github.com/developmentseed/ram-deployment/blob/master/.kes/config.yml

@danielfdsilva
Copy link
Collaborator Author

@olafveerman Test fixed, and documentation added.

As for the ram-deployment repo, should we include the variables to integrate with RAH? Anything else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants