Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/prettier #12

Merged
merged 4 commits into from
Feb 17, 2021
Merged

Feature/prettier #12

merged 4 commits into from
Feb 17, 2021

Conversation

poltak
Copy link
Member

@poltak poltak commented Jan 21, 2021

This sets up prettier in the repo.

I haven't done the format of all existing files yet though, as I feel a bit unfair taking all the "git credit" for lots of the code in here that I haven't written. @ShishKabab maybe you could do that? You might want to ignore the submodules though when you do it, so from the repo root you could do:

  1. yarn
  2. echo external/ >> .prettierignore
  3. yarn prettier --write .
  4. git restore .prettierignore

then commit everything

- doesn't enable it either - leaves it up to devs' global settings
- was having trouble getting my local vscode setup working with the current config right
@ShishKabab
Copy link
Member

I'll do this once we don't have other work going in branches, so we don't get a bunch of merge conflicts. Thanks for tackling this!

@ShishKabab ShishKabab merged commit 1c36e3a into develop Feb 17, 2021
@ShishKabab ShishKabab deleted the feature/prettier branch February 17, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants