Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTNI-281 ⁃ Store only one page object per URL #17

Closed
blackforestboi opened this issue May 1, 2017 · 2 comments
Closed

MTNI-281 ⁃ Store only one page object per URL #17

blackforestboi opened this issue May 1, 2017 · 2 comments

Comments

@blackforestboi
Copy link
Member

blackforestboi commented May 1, 2017

Gerben provided a nice deduplication framework, where we can flexibly define the rules on when and if to store duplicates.

I may be wrong about that, but It seems to me that we currently won't need to store a new object for every visit, as long as there is no versioning.
It also would make it simpler if we just had one version per page and could index all of them, instead of worrying which versions to index. We may want to store and search multiple versions later though.


Want to back this issue? ?utm_campaign=plugin&utm_content=tracker%2F59103681&utm_medium=issues&utm_source=github Post a bounty on it! We accept bounties via ?utm_campaign=plugin&utm_content=tracker%2F59103681&utm_medium=issues&utm_source=github Bountysource.

poltak pushed a commit that referenced this issue Jun 19, 2017
# Conflicts:
#	src/options/base.css
#	src/options/containers/import/index.jsx
#	src/options/containers/settings/index.jsx
#	src/options/layout.jsx
#	src/options/main.jsx
#	src/overview/main.jsx
poltak pushed a commit that referenced this issue Jun 23, 2017
# Conflicts:
#	src/options/base.css
#	src/options/containers/import/index.jsx
#	src/options/containers/settings/index.jsx
#	src/options/layout.jsx
#	src/options/main.jsx
#	src/overview/main.jsx
@blackforestboi
Copy link
Member Author

New thoughts:

  • For now, we should only store one page object per url - the most recent. And add all other visits as visit objects.

Expected behaviour:
Whenever a page is visited/imported, that is already existent: replace old version of text/content AND freeze-dry with the most recent.
The freeze dry versions can easily get very big. one page can have anything between 100kb-2MB
So we should reduce the amount of freeze dry as much as possible.

Later we might also think of adding some more metrics to the decision to keep a freeze dry version in the first place. Maybe something related to how long a person stays on an article, or only when a user choses to store the freeze dry version manually.

poltak pushed a commit that referenced this issue Jul 5, 2017
# Conflicts:
#	src/options/base.css
#	src/options/containers/import/index.jsx
#	src/options/containers/settings/index.jsx
#	src/options/layout.jsx
#	src/options/main.jsx
#	src/overview/main.jsx
@blackforestboi blackforestboi added this to Up Next in Re-launch Release Aug 25, 2017
@blackforestboi
Copy link
Member Author

fixed with #69

@blackforestboi blackforestboi moved this from Up Next to Done! Yeah! in Re-launch Release Nov 9, 2017
@blackforestboi blackforestboi changed the title Store only one page object per URL MTNI-281 ⁃ Store only one page object per URL Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

2 participants