Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-TOS & re-onboard all users #1450

Merged
merged 1 commit into from Aug 20, 2020

Conversation

hspinks
Copy link
Collaborator

@hspinks hspinks commented Aug 20, 2020

Closes #1302

Keeps the user's preference for disabling analytics if they previously opted out (tested locally). Note this will still show the user the notification permission request screen even if they have already turned it on or rejected the native dialog.


Please follow this checklist. Please check each appropriate box (put an 'x' or check it after creating the PR).

  • REQUIRED: Do you have an Issue assigned to you for this PR?
  • Provided detailed pull request description and a succinct title
  • Tested your changes, especially after any code review iterations.
  • Included any relevant screenshots of UI updates.
  • Followed the Contributor Guidelines.
  • Verified all contributions are properly licensed pursuant to the LICENSE file in the root of the repository.
  • Verified your name is in the content/credits.yaml file (if you want it to be).

@hspinks hspinks added the client Mobile client/app component label Aug 20, 2020
@hspinks hspinks added this to the v1.0 - Nigeria milestone Aug 20, 2020
@hspinks hspinks merged commit e28e016 into WorldHealthOrganization:master Aug 20, 2020
@hspinks hspinks deleted the feature/re-onboard branch August 20, 2020 06:41
brunobowden added a commit to brunobowden/app that referenced this pull request Dec 19, 2020
- OnboardingCompletedV2 repeats same process as in WorldHealthOrganization#1450
- It is increasingly unwieldy but the safest since used previously
- `LegalCompletedTimestamp` recorded for facilitating new approach
@brunobowden brunobowden mentioned this pull request Dec 19, 2020
2 tasks
brunobowden added a commit that referenced this pull request Dec 19, 2020
* Re-TOS and re-Onboard all users

- OnboardingCompletedV2 repeats same process as in #1450
- It is increasingly unwieldy but the safest since used previously
- `LegalCompletedTimestamp` recorded for facilitating new approach

* Fixed analytics onboarding logic

- Enable Analytics only for first onboarding
- Dropped redundant check for `getAnalyticsEnabled`

* Update onboarding_page.dart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Mobile client/app component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require re-tos/re-onboarding for all users
2 participants