Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify UTF-8 encoding whenever working with text #26

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

pkgw
Copy link

@pkgw pkgw commented Oct 5, 2020

Some Windows Pythons default to encodings like CP1252, and we want to make sure that we don't accidentally use that.

Some Windows Pythons default to encodings like CP1252, and we want to
make sure that we don't accidentally use that.
@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #26 into master will not change coverage.
The diff coverage is 60.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #26   +/-   ##
=======================================
  Coverage   86.02%   86.02%           
=======================================
  Files          12       12           
  Lines        1882     1882           
=======================================
  Hits         1619     1619           
  Misses        263      263           
Impacted Files Coverage Δ
toasty/pipeline.py 79.07% <60.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 939324b...d069b77. Read the comment docs.

@pkgw pkgw merged commit fe19e1d into WorldWideTelescope:master Oct 5, 2020
@pkgw pkgw deleted the next branch October 5, 2020 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant