Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work for LSST demo #27

Merged
merged 12 commits into from
Oct 12, 2020
Merged

Work for LSST demo #27

merged 12 commits into from
Oct 12, 2020

Conversation

pkgw
Copy link

@pkgw pkgw commented Oct 12, 2020

No description provided.

pkgw added 12 commits October 8, 2020 08:44
If the cascade was starting at a sufficiently deep level, the ready queue could simply fill up
before any quartets were completed. Just allow it to become unboundedly large.
This reads an image, allows the caller to modify it, and then rewrites it. The key
is that this uses file locking to make sure that multiple processes don't operate on
the same tile at the same time, as might happen when doing a parallelized multi-segment
tiling operation.
Now that we have centralized the image I/O stuff, we don't need to
disambiguate the method names anymore.
Azure's conda has updated to Python 3.9, but astropy isn't yet available
for it, so we need to explicitly specify an older version to get it for
the docs and coverage builds.
@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #27 into master will decrease coverage by 6.92%.
The diff coverage is 12.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
- Coverage   86.02%   79.09%   -6.93%     
==========================================
  Files          12       13       +1     
  Lines        1882     2057     +175     
==========================================
+ Hits         1619     1627       +8     
- Misses        263      430     +167     
Impacted Files Coverage Δ
toasty/multi_wcs.py 0.00% <0.00%> (ø)
toasty/image.py 71.87% <6.66%> (-4.69%) ⬇️
toasty/study.py 84.34% <12.50%> (-11.66%) ⬇️
toasty/pyramid.py 85.21% <35.71%> (-6.13%) ⬇️
toasty/merge.py 95.72% <100.00%> (+0.11%) ⬆️
toasty/toast.py 98.87% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe19e1d...8fb101f. Read the comment docs.

@pkgw
Copy link
Author

pkgw commented Oct 12, 2020

This puts a bit of a ding in our code coverage, but we can't test it effectively until reproject learns how to optimize WCS given only shapes (astropy/reproject#242). I want to get these changes merged in so that I can start working on the next set of features, so I'm gonna take the hit.

@pkgw pkgw merged commit c707cae into WorldWideTelescope:master Oct 12, 2020
@pkgw pkgw deleted the lsst-demo branch October 12, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant