Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toasty/merge.py: oops, clear our downsampling buffer on init #31

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

pkgw
Copy link

@pkgw pkgw commented Nov 18, 2020

make_maskable_buffer() doesn't initialize the buffer, for efficiency. We didn't initialize it either, leading to artifacts in the first few tiles processed.

`make_maskable_buffer()` doesn't initialize the buffer, for efficiency.
We didn't initialize it either, leading to artifacts in the first few
tiles processed.
@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #31 (4bb4fbb) into master (01da964) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   78.15%   78.17%   +0.01%     
==========================================
  Files          14       14              
  Lines        2188     2190       +2     
==========================================
+ Hits         1710     1712       +2     
  Misses        478      478              
Impacted Files Coverage Δ
toasty/merge.py 95.79% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01da964...4bb4fbb. Read the comment docs.

@pkgw pkgw merged commit d013676 into WorldWideTelescope:master Nov 18, 2020
@pkgw pkgw deleted the fix-cascade branch November 18, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant