Fix the Finder scope buttons in Chrome #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On recent Firefox the div wasn't fitting in anymore, resulting in ugly overflow.
On recent Chrome, turning "hidden" on and off seems to somehow interfere with event handling, such that the buttons on the finder scope weren't working anymore [1]. Despite lots of research I can't figure out what exactly is causing the problem, but it's very likely a new behavior since this code must have been tested on Chrome historically. The jQuery fadeIn/fadeOut functions end up altering the element CSS to use "display: none", which as far as I can tell is an equivalent flag for our purposes. So if we don't mess with "hidden" at all and just pay attention to the "display" state, things seem to work again. Fixes WorldWideTelescope#312. [1]: For posterity: in my testing, click events seemed to be going through, but they would be targeting the toplevel `body` element, not the `a.btn` elements, breaking the processing used by jQuery/Angular. Bizarre.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #312. Also improve fix the coordinate info layout in recent Firefox.