Ensure that source list message doesn't try to send proxy #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n individual message dispatchers.
pkgw
added a commit
to pkgw/pywwt
that referenced
this pull request
May 30, 2023
This pulls in the following fix: WorldWideTelescope/wwt-webgl-engine#251
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the same problem as #218, just in a slightly different place. That PR ensured that the last selected source couldn't be sent as a proxy, but we can actually get the same issue when sending the message describing the list of currently selected sources. This is a problem for downstream applications where the app's
statusMessageDestinationis non-null (e.g. pywwt), since thepostMessagecall app-side will fail as the proxy can't be cloned.This PR refactors the
isProxy/toRawlogic into theprepareForMessagingmethod, which gets called during the dispatch for both message types (and fits logically, as this is necessary to prepare the data for messaging).